refactor(pytest): integrate EIP report generation into spec_version_checker plugin

.github/workflows/check_eip_versions.yaml

@@ -39,11 +39,6 @@ jobs:
           # Always return success to GitHub Actions
           exit 0
 
-      - name: Generate report file
-        if: steps.check-eip.outputs.exit_code != 0
-        run: |
-          uv run python .github/scripts/generate_eip_report.py ./reports/eip_check_output.txt ./reports/outdated_eips.md
-
       - name: Create Issue From File
         if: steps.check-eip.outputs.exit_code != 0
         uses: peter-evans/create-issue-from-file@e8ef132d6df98ed982188e460ebb3b5d4ef3a9cd

docs/CHANGELOG.md

@@ -38,6 +38,10 @@ Users can select any of the artifacts depending on their testing needs for their
 - 🐞 zkEVM marked tests have been removed from `tests-deployed` tox environment into its own separate workflow `tests-deployed-zkevm` and are filled by `evmone-t8n` ([#1617](https://github.com/ethereum/execution-spec-tests/pull/1617)).
 - ✨ Field `postStateHash` is now added to all `blockchain_test` and `blockchain_test_engine` tests that use `exclude_full_post_state_in_output` in place of `postState`. Fixes `evmone-blockchaintest` test consumption and indirectly fixes coverage runs for these tests ([#1667](https://github.com/ethereum/execution-spec-tests/pull/1667)).
 
+#### `check_eip_versions`
+
+- 🔀 Refactor: Move EIP version report generation from external script into the `spec_version_checker` pytest plugin to eliminate brittle regex parsing of console output and improve maintainability.
+
 #### `consume`
 
 #### `execute`

src/pytest_plugins/spec_version_checker/spec_version_checker.py

@@ -6,6 +6,8 @@
 import os
 import re
 import textwrap
+from dataclasses import dataclass
+from pathlib import Path
 from types import ModuleType
 from typing import Any, List, Optional, Set
 
@@ -22,6 +24,17 @@
 )
 
 
+@dataclass
+class EIPVersionFailure:
+    """Represents a failure in EIP version check."""
+
+    file_path: str
+    eip_spec_name: str
+    eip_spec_url: str
+    referenced_version: str
+    latest_version: str
+
+
 def pytest_addoption(parser):
     """Add Github token option to pytest command line options."""
     group = parser.getgroup(
@@ -52,6 +65,8 @@ def pytest_configure(config):
         "eip_version_check: a test that tests the reference spec defined in an EIP test module.",
     )
 
+    config._eip_version_failures = []
+
     github_token = config.getoption("github_token") or os.environ.get("GITHUB_TOKEN")
 
     if not github_token:
@@ -113,7 +128,11 @@ def is_test_for_an_eip(input_string: str) -> bool:
     return False
 
 
-def test_eip_spec_version(module: ModuleType, github_token: Optional[str] = None):
+def test_eip_spec_version(
+    module: ModuleType,
+    github_token: Optional[str] = None,
+    config: Optional[pytest.Config] = None,
+):
     """
     Test that the ReferenceSpec object as defined in the test module
     is not outdated when compared to the remote hash from
@@ -122,8 +141,18 @@ def test_eip_spec_version(module: ModuleType, github_token: Optional[str] = None
     Args:
         module: Module to test
         github_token: Optional GitHub token for API authentication
+        config: Pytest config object, which must be provided.
 
     """
+    # Ensure config is available
+    if config is None:
+        # This case should ideally not happen if called via EIPSpecTestItem.runtest
+        # or if pytest passes config correctly in other scenarios.
+        # Fallback or error if essential. For now, assume it's provided.
+        pytest.fail(
+            "pytest.Config not available in test_eip_spec_version. "
+            "This is an issue with the plugin itself."
+        )
     ref_spec = get_ref_spec_from_module(module, github_token=github_token)
     assert ref_spec, "No reference spec object defined"
 
@@ -143,6 +172,24 @@ def test_eip_spec_version(module: ModuleType, github_token: Optional[str] = None
             f"Reference spec URL: {ref_spec.api_url()}."
         ) from e
 
+    if not is_up_to_date:
+        failure_data = EIPVersionFailure(
+            file_path=str(module.__file__),
+            eip_spec_name=ref_spec.name(),
+            eip_spec_url=ref_spec.api_url(),
+            referenced_version=ref_spec.known_version(),
+            latest_version=ref_spec.latest_version(),
+        )
+        # Ensure _eip_version_failures list exists, though it should by pytest_configure
+        if hasattr(config, "_eip_version_failures"):
+            config._eip_version_failures.append(failure_data)
+        else:
+            # This case should not happen if pytest_configure runs as expected.
+            # Log an error or handle as appropriate.
+            print(
+                "Warning: config._eip_version_failures not found. Failure data cannot be recorded."
+            )
+
     assert is_up_to_date, message
 
 
@@ -189,7 +236,9 @@ def from_parent(cls, parent: Node, **kw: Any) -> "EIPSpecTestItem":
 
     def runtest(self) -> None:
         """Define the test to execute for this item."""
-        test_eip_spec_version(self.module, github_token=self.github_token)
+        test_eip_spec_version(
+            self.module, github_token=self.github_token, config=self.session.config
+        )
 
     def reportinfo(self) -> tuple[str, int, str]:
         """
@@ -217,3 +266,84 @@ def pytest_collection_modifyitems(
     for item in new_test_eip_spec_version_items:
         item.add_marker("eip_version_check", append=True)
     items.extend(new_test_eip_spec_version_items)
+
+
+def generate_eip_report_markdown(failures: List[EIPVersionFailure], run_id: str) -> str:
+    """Generate a markdown report for EIP version check failures."""
+    summary_table_header = (
+        "| File Path | EIP | Referenced Version | Latest Version |\n"
+        "|-----------|-----|--------------------|----------------|\n"
+    )
+    summary_table_rows = []
+    for failure in failures:
+        eip_match = re.search(r"eip-?(\d+)", failure.eip_spec_name, re.IGNORECASE)
+        if not eip_match:
+            eip_match = re.search(r"eip-?(\d+)", failure.file_path, re.IGNORECASE)
+        eip_number_str = f"EIP-{eip_match.group(1)}" if eip_match else "Unknown"
+
+        # Ensure the URL points to the commit history for better context
+        eip_link_url = failure.eip_spec_url.replace("blob/", "commits/")
+
+        row = (
+            f"| {failure.file_path} | [{eip_number_str}]({eip_link_url}) | "
+            f"`{failure.referenced_version}` | `{failure.latest_version}` |"
+        )
+        summary_table_rows.append(row)
+
+    fail_details_parts = []
+    for failure in failures:
+        detail = (
+            f"File: `{failure.file_path}`\n"
+            f"Spec Name: `{failure.eip_spec_name}`\n"
+            f"Spec URL: {failure.eip_spec_url}\n"
+            f"Referenced Version: `{failure.referenced_version}`\n"
+            f"Latest Version: `{failure.latest_version}`\n"
+            "---\n"
+        )
+        fail_details_parts.append(detail)
+
+    report_template = textwrap.dedent(
+        """\
+        # EIP Version Check Report (Run ID: {run_id})
+
+        ## Summary of Outdated EIP References
+
+        {summary_table_header}{summary_table_rows_str}
+
+        ## Outdated EIP References Details
+
+        {fail_details_str}
+        """
+    )
+
+    return report_template.format(
+        run_id=run_id,
+        summary_table_header=summary_table_header,
+        summary_table_rows_str="\n".join(summary_table_rows),
+        fail_details_str="\n".join(fail_details_parts),
+    )
+
+
+def pytest_sessionfinish(session):
+    """
+    Call after the whole test session finishes.
+    Generate a report if there are any EIP version failures.
+    """
+    failures = session.config._eip_version_failures
+    if failures:
+        run_id = os.environ.get("GITHUB_RUN_ID", "local-run")
+        report_content = generate_eip_report_markdown(failures, run_id)
+        report_file_path_str = "./reports/outdated_eips.md"
+
+        report_file_path = Path(report_file_path_str)
+        report_file_path.parent.mkdir(parents=True, exist_ok=True)
+
+        with open(report_file_path, "w") as f:
+            f.write(report_content)
+
+        print(
+            f"\nEIP Version Check: {len(failures)} outdated EIP references found. "
+            f"Report generated at {report_file_path_str}"
+        )
+    else:
+        print("\nEIP Version Check: No outdated EIP references found.")