Skip to content

refactor(forks): Refactor extract fork until from logic, add BPO forks by default #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

marioevz
Copy link
Member

🗒️ Description

Refactor Validity Marker Logic in src/pytest_plugins/forks/forks.py

Add Fork Adapters to ethereum_test_forks.helpers

Adds pydantic adapters to Fork and ForkSet.

This allows to add click parameters that automatically parse a comma-separated string of fork names into the appropriate fork type.

Add get_selected_fork_set to ethereum_test_forks.helpers

Extracts the --fork, --until and --from selector logic from the forks pytest plugin into ethereum_test_forks, in order to reuse this logic in other tools (e.g. #2045).

Refactor ValidityMarker Logic in Forks Pytest Plugin

Refactors the logic to select the forks a test should run in given a list of validity markers.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant