refactor(forks): Refactor extract fork until from logic, add BPO forks by default #2051
+296
−239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Refactor Validity Marker Logic in
src/pytest_plugins/forks/forks.py
Add Fork Adapters to
ethereum_test_forks.helpers
Adds pydantic adapters to
Fork
andForkSet
.This allows to add click parameters that automatically parse a comma-separated string of fork names into the appropriate fork type.
Add
get_selected_fork_set
toethereum_test_forks.helpers
Extracts the
--fork
,--until
and--from
selector logic from the forks pytest plugin intoethereum_test_forks
, in order to reuse this logic in other tools (e.g. #2045).Refactor
ValidityMarker
Logic in Forks Pytest PluginRefactors the logic to select the forks a test should run in given a list of validity markers.
🔗 Related Issues or PRs
N/A.
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.