Added ethrex client #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
reviewed
Apr 25, 2025
mpaulucci
reviewed
Apr 25, 2025
mpaulucci
reviewed
Apr 25, 2025
mpaulucci
reviewed
Apr 25, 2025
|
|
||
| # Replace config in input. | ||
| . + { | ||
| "config": { |
There was a problem hiding this comment.
let's review our chain config and see which fields we support
fedacking
force-pushed
the
feat/ethrex-integration
branch
from
1427f13 to
e137bbd
Compare
fedacking
force-pushed
the
feat/ethrex-integration
branch
from
e137bbd to
e958ef4
Compare
mpaulucci
reviewed
May 8, 2025
| # Configure RPC. | ||
| FLAGS="$FLAGS --http.addr=0.0.0.0 --authrpc.addr=0.0.0.0" | ||
|
|
||
| if [ "$HIVE_TERMINAL_TOTAL_DIFFICULTY" != "" ]; then |
There was a problem hiding this comment.
we don't support pre merge so we should exist with an error on the "else" of this if
There was a problem hiding this comment.
After testing again this with our branch, even if we don't support it, some tests like "rpc-compat" still sends it without expecting us to use it. The correct setting was letting it continue in that scenario, but I have added a warning.
mpaulucci
reviewed
May 8, 2025
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
is this a copy of the other genesis files?
There was a problem hiding this comment.
Yes. Looking into it all of the clients use either the same or a very similar genesis file.
mpaulucci
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.