Skip to content

Conversation

schoffelen
Copy link
Contributor

to facilitate reorganization of the website.

@schoffelen schoffelen marked this pull request as draft September 26, 2024 08:24
@schoffelen schoffelen marked this pull request as ready for review November 18, 2024 10:06
@robertoostenveld
Copy link
Member

a lot of files were changed. How far (in percentage or so) do you think you got?

@robertoostenveld
Copy link
Member

The FAQ directory looks now clean and complete, right? Shall I review, test and merge?

@schoffelen
Copy link
Contributor Author

I think that this one indeed is ready for review: I did a full sweep of the FAQ folder + the assets/faq

Next in line is the example scripts, I haven't touched those, yet

@robertoostenveld
Copy link
Member

I will pull this branch and deploy locally to see whether there are any issues. If not, I'll merge.

@robertoostenveld robertoostenveld self-assigned this Nov 18, 2024
@schoffelen
Copy link
Contributor Author

I rendered the page locally and fixed some broken links.

I tried the wget -spider but did not manage to extract good intel from that. Hence I followed all the links on the faq landing page, and all seems in order after my latest commit. I haven't checked the pages with images (since I renamed the folders)

@robertoostenveld
Copy link
Member

Let me give it a try as well.

@robertoostenveld
Copy link
Member

I noticed that there are non-functional redirections, for example http://127.0.0.1:4000/faq/how_can_i_import_my_own_dataformat works on master, but not on fname_short. It should redirect to http://127.0.0.1:4000/faq/dataformat_own/ and the redirect is also in the md file... weird.

@robertoostenveld
Copy link
Member

Ah, found it: the redirect-from: in the header should be redirect_from: with an underscore. I will change it.

@robertoostenveld
Copy link
Member

Ok, I believe all links are working again. Note that quite a few of the broken links were not due to the faq renaming, but due to previous refactoring of figures and workshop pages, but these had not been detected yet.

@robertoostenveld robertoostenveld merged commit a731abf into master Nov 28, 2024
@robertoostenveld robertoostenveld deleted the fname_short branch April 1, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants