Skip to content

Add vite 6 to peerDependencies #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

silverwind
Copy link
Contributor

As far as I'm aware, the plugin API of v6 is compatible to v5, so this should be all that's needed to support v6.

As far as I'm aware, the plugin API of v6 is compatible to v5, so this should be all that's needed to support v6.
@silverwind
Copy link
Contributor Author

Test failure is unrelated.

@Sceat
Copy link

Sceat commented Jan 15, 2025

could this be merged?

@nicky1038
Copy link

nicky1038 commented Jan 16, 2025

Sorry for posting this here but it can help somebody.
Vite allows using Rollup plugins since they have compatible plugin APIs, so one might also use @rollup/plugin-yaml for converting yaml to esm.

@silverwind
Copy link
Contributor Author

While we are talking alternatives, I also started working on a new minimal yaml plugin, no schema support etc, but might be enough for some people.

@tonyketcham tonyketcham merged commit ebdd886 into figma:main Feb 21, 2025
0 of 6 checks passed
@tonyketcham
Copy link
Contributor

Apologies for the delay attending to this - I've merged and have taken a look at preventing major version bumps from causing this issue again in future, optimistically assuming the API used in this plugin is quite stable and has not changed in a breaking way over 4 major version releases: d804798

@tonyketcham tonyketcham mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants