Feature/netsuite2 fiscal year end #61
Conversation
CHANGELOG.md
Outdated
|
|
||
| ## Breaking Schema Changes | ||
| - Added optional `fiscalcalendar` source table to support accurate fiscal year start dates (currently defaulted to calendar year). This table and related models (`stg_netsuite2__fiscal_calendar_tmp` and `stg_netsuite2__fiscal_calendar`) are disabled by default. | ||
| - To enable: turn on the fiscalcalendar table in the connection schema tab. |
There was a problem hiding this comment.
I would add something this is for Quickstart users.
There was a problem hiding this comment.
Updated.
| # dbt_netsuite_source v0.12.0 | ||
|
|
||
| ## Breaking Schema Changes | ||
| - Added optional `fiscalcalendar` source table to support accurate fiscal year start dates (currently defaulted to calendar year). This table and related models (`stg_netsuite2__fiscal_calendar_tmp` and `stg_netsuite2__fiscal_calendar`) are disabled by default. To enable this feature: |
There was a problem hiding this comment.
| - Added optional `fiscalcalendar` source table to support accurate fiscal year start dates (currently defaulted to calendar year). This table and related models (`stg_netsuite2__fiscal_calendar_tmp` and `stg_netsuite2__fiscal_calendar`) are disabled by default. To enable this feature: | |
| - Added optional `fiscalcalendar` source table to support accurate fiscal year start dates (currently defaulted to calendar year). This table and related models (`stg_netsuite2__fiscal_calendar_tmp` and `stg_netsuite2__fiscal_calendar`) are disabled by default. ([PR #61](https://github.com/fivetran/dbt_netsuite_source/pull/61)) | |
| - To enable this feature: |
There was a problem hiding this comment.
"PR" added, but I prefer the structure where each individual update is detailing a change and how to take advantage of it. Keeping the "To enable this feature:" within the same primary bullet as before and letting the sub-bullets be the enable steps.
CHANGELOG.md
Outdated
| - dbt Core users: enable the fiscalcalendar table in the connection schema tab and also set the `netsuite2__fiscal_calendar_enabled` variable to true (default is false). | ||
|
|
||
| ## Documentation | ||
| - Corrected references to connectors and connections in the README. ([#60](https://github.com/fivetran/dbt_netsuite_source/pull/60)) |
There was a problem hiding this comment.
| - Corrected references to connectors and connections in the README. ([#60](https://github.com/fivetran/dbt_netsuite_source/pull/60)) | |
| - Corrected references to connectors and connections in the README. ([PR #60](https://github.com/fivetran/dbt_netsuite_source/pull/60)) |
There was a problem hiding this comment.
Updated
|
|
||
| ## Breaking Schema Changes | ||
| - Added optional `fiscalcalendar` source table to support accurate fiscal year start dates (currently defaulted to calendar year). This table and related models (`stg_netsuite2__fiscal_calendar_tmp` and `stg_netsuite2__fiscal_calendar`) are disabled by default. To enable this feature: | ||
| - Quickstart users: enable the fiscalcalendar table in the connection schema tab. |
There was a problem hiding this comment.
I noticed in the Fivetran schema tab this table is capitalized as FiscalCalendar. Should we update with this casing syntax or do we think this is ok?
There was a problem hiding this comment.
This should be fine since this is how the table will look in the destination. As long as the casing is the same in the downstream quickstart.yml that's what really matters.
models/stg_netsuite2.yml
Outdated
| - name: fiscal_month | ||
| description: The starting month of the fiscal calendar (e.g., JAN for January, APR for April). | ||
| - name: is_default | ||
| description: "Boolean flag indicating whether this is the default fiscal calendar. |
There was a problem hiding this comment.
| description: "Boolean flag indicating whether this is the default fiscal calendar. | |
| description: Boolean flag indicating whether this is the default fiscal calendar. |
There was a problem hiding this comment.
Updated. Thanks for catching!
There was a problem hiding this comment.
@fivetran-joemarkiewicz A few suggestions, nothing blocking, lgtm.
PR Overview
This PR will address the following Issue/Feature: dbt_netsuite Issue #159
Submission Checklist
Submitter:
Reviewer: