Skip to content

Fix typo and add Ethernet support #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix typo and add Ethernet support #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77afea5
Fix typos and add Ethernet support
tonyxforce Aug 15, 2025
bcd007c
Change to spaces instead of tabs
tonyxforce Aug 15, 2025
755a6ed
Automatically detect ETH vs WiFi
tonyxforce Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ESPAsyncE131.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,21 @@ bool ESPAsyncE131::initMulticast(uint16_t universe, uint8_t n) {
if (udp.listenMulticast(address, E131_ListenPort)) {
ip4_addr_t ifaddr;
ip4_addr_t multicast_addr;

ifaddr.addr = static_cast<uint32_t>(WiFi.localIP());
for (uint8_t i = 1; i < n; i++) {

if(ETH.linkUp())
ifaddr.addr = static_cast<uint32_t>(ETH.localIP());
else if(WiFi.isConnected())
ifaddr.addr = static_cast<uint32_t>(WiFi.localIP());
else
ifaddr.addr = static_cast<uint32_t>(IPAddress(0,0,0,0));
for (uint8_t i = 1; i < n; i++) {
multicast_addr.addr = static_cast<uint32_t>(IPAddress(239, 255,
(((universe + i) >> 8) & 0xff), (((universe + i) >> 0)
& 0xff)));
igmp_joingroup(&ifaddr, &multicast_addr);
}

udp.onPacket(std::bind(&ESPAsyncE131::parsePacket, this,
udp.onPacket(std::bind(&ESPAsyncE131::parsePacket, this,
std::placeholders::_1));

success = true;
Expand Down Expand Up @@ -160,7 +165,7 @@ void ESPAsyncE131::parsePacket(AsyncUDPPacket _packet)
break;
}

// Are we looknig for a new source?
// Are we looking for a new source?
if((0 != LastAcceptedSource.PdusToIgnore) &&
(sbuff->priority < LastAcceptedSource.priority))
{
Expand Down
15 changes: 8 additions & 7 deletions ESPAsyncE131.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,15 @@
#define ESPASYNCE131_H_

#ifdef ESP32
#include <WiFi.h>
#include <AsyncUDP.h>
#elif defined (ESP8266)
#include <ESPAsyncUDP.h>
#include <ESP8266WiFi.h>
#include <ESP8266WiFiMulti.h>
#include <AsyncUDP.h>
#include <ETH.h>
#include <WiFi.h>
#elif defined(ESP8266)
#include <ESPAsyncUDP.h>
#include <ESP8266WiFi.h>
#include <ESP8266WiFiMulti.h>
#else
#error Platform not supported
#error Platform not supported
#endif

#include <lwip/ip_addr.h>
Expand Down