-
Notifications
You must be signed in to change notification settings - Fork 3
ci update #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci update #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @perazz! Thanks!
There's a few things that I am not sure about and need to thoroughly check which is why I opened #24. That aside the version bump and the build changes should be two separate PRs, since they are conceptually different. There's a checklist in the README with the changes necessary for a version bump. I would like to hold on merging this until I had a chance to look into the new GitHub runners and the setup build scripts I wrote for macos in more detail. I will get to it during the weekend. |
OK so I reverted the fpm version bump and that will be part of a separate PR. |
I think you're right to check @gnikit. Please note that:
I've updated it with the latest release and now it's general:
so it looks like the current values should still be valid. |
I looked into this during the weekend, the sdist build is broken on my ARM MacOS, which is really concerning. |
@gnikit would you mind to review this one? I'm asking here in the comment as I don't have permission to request you as a reviewer. |
This CI update is necessary to prepare a
fpm v0.11.0
release.v13.0
gfortran-12
This should fix #23 #24, thank you @jalvesz @gnikit.