Skip to content

ci update #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

ci update #25

wants to merge 19 commits into from

Conversation

perazz
Copy link
Member

@perazz perazz commented Mar 20, 2025

This CI update is necessary to prepare a fpm v0.11.0 release.

  • bump macOS compatibility to v13.0
  • bump compiler to gfortran-12
  • Update MacPython script to latest release

This should fix #23 #24, thank you @jalvesz @gnikit.

Copy link

@jalvesz jalvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @perazz! Thanks!

@gnikit
Copy link
Member

gnikit commented Mar 20, 2025

There's a few things that I am not sure about and need to thoroughly check which is why I opened #24.
They mostly have to do with the new linker paths and whether the cross-compiled libraries we are manually linking to are compatible with the ABI of gfortran-12.

That aside the version bump and the build changes should be two separate PRs, since they are conceptually different. There's a checklist in the README with the changes necessary for a version bump.

I would like to hold on merging this until I had a chance to look into the new GitHub runners and the setup build scripts I wrote for macos in more detail. I will get to it during the weekend.

@perazz perazz changed the title fpm v0.11.0 release ci update Mar 20, 2025
@perazz
Copy link
Member Author

perazz commented Mar 20, 2025

OK so I reverted the fpm version bump and that will be part of a separate PR.

@perazz
Copy link
Member Author

perazz commented Mar 20, 2025

I think you're right to check @gnikit. Please note that:

  • the deployment target was hardcoded in the script and I believe it was inaccurate, since the wheel was targeting macOS 11:
    # The gfortran downloads build for macos 10.9
    local target="10_9"

I've updated it with the latest release and now it's general:

    # macOS 32-bit arch is i386
    [ "$plat" == "i686" ] && plat="i386"
    local target=$(echo $MACOSX_DEPLOYMENT_TARGET | tr .- _)
  • it seems like the cross-compiler is still gfortran 11.3.0 and the outputs are unchanged: from the workflow log,

before_build returns

@@@ FC: /opt/gfortran-darwin-arm64-cross/bin/arm64-apple-darwin20.0.0-gfortran
  + echo '@@@ FC:' /opt/gfortran-darwin-arm64-cross/bin/arm64-apple-darwin20.0.0-gfortran
  + echo '@@@ FC_ARM64_LDFLAGS:' -L/opt/gfortran-darwin-arm64-cross/lib/gcc/arm64-apple-darwin20.0.0/11.3.0 -Wl,-rpath,/opt/gfortran-darwin-arm64-cross/lib/gcc/arm64-apple-darwin20.0.0/11.3.0
@@@ FC_ARM64_LDFLAGS: -L/opt/gfortran-darwin-arm64-cross/lib/gcc/arm64-apple-darwin20.0.0/11.3.0 -Wl,-rpath,/opt/gfortran-darwin-arm64-cross/lib/gcc/arm64-apple-darwin20.0.0/11.3.0

so it looks like the current values should still be valid.

@gnikit
Copy link
Member

gnikit commented Mar 24, 2025

I looked into this during the weekend, the sdist build is broken on my ARM MacOS, which is really concerning.

@perazz
Copy link
Member Author

perazz commented Mar 24, 2025

  • build wheels from macos-13 to require >=13 compatibility. The cross-compiler does not appear to work on macos-14 (likely due to MACOSX_DEPLOYMENT_TARGET = 13.0)
  • fix warnings on the classifiers

@gnikit would you mind to review this one? I'm asking here in the comment as I don't have permission to request you as a reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants