Skip to content

fix: enable config_crypto_ecdsa for the module verification #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2025
Merged

Conversation

5kt
Copy link
Contributor

@5kt 5kt commented Aug 19, 2025

What this PR does / why we need it:
CONFIG_CRYPTO_ECDSA needs to be enabled in order for the module verification to work.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@Akendo
Copy link
Contributor

Akendo commented Aug 20, 2025

So the problem was that they switched to a different key algorithm that we didn't support?

Copy link

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please note minor question below.

@@ -1,6 +1,6 @@
pkg=linux
version_orig=6.12.42
version="$version_orig-2"
version="$version_orig-3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we haven't usually counted up the version_suffix=gl0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, @fwilhe ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NotTheEvilOne @5kt the problem is that this now created a release.. I think we should revert to what we had before to avoid this.

@fwilhe fwilhe merged commit b52e5a9 into main Aug 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants