Add .sh env hook for setting GZ_CONFIG_PATH #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This correctly sets the GZ_CONFIG_PATH in the same way as the .dsv file. Signed-off-by: Nathan Wiebe Neufeldt <nwiebeneufeldt@clearpath.ai>
|
Ping @azeey for review |
1 similar comment
|
Ping @azeey for review |
|
Sorry for the delay. I'll plan to review this this week. |
azeey
reviewed
Dec 12, 2024
| @@ -0,0 +1,3 @@ | |||
| if [ -d "$AMENT_CURRENT_PREFIX/opt/@PROJECT_NAME@/share/gz" ]; then | |||
| ament_prepend_unique_value GZ_CONFIG_PATH "$AMENT_CURRENT_PREFIX/opt/@PROJECT_NAME@/share/gz" | |||
There was a problem hiding this comment.
I tested this by building a colcon workspace with the vendor packages and deleting the .dsv files in the install directories. What I found is that since $AMENT_CURRENT_PREFIX was /opt/ros/rolling, the condition here is never satisfied and GZ_CONFIG_PATH is never set. So I guess this would only work if you're installing the vendor packages to /opt/ros/<ros-version>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For systems not using colcon's or ament's
.dsvfiles for initializing the environment, having only "dummy".shhooks means that theGZ_CONFIG_PATHenvironment variable does not get set correctly. The proposed change is to define a "real".shhook with the proper logic to initialize the environment.This generates the exact same output as was proposed in gazebo-release/gz_common_vendor#5.