Jetty: support package names without version number #17
Conversation
Major version numbers have been removed from all packages in Gazebo Jetty (except gz-tools2), so update the template to remove the version number and the unversioned cmake config template and the extras cmake template, which are no longer needed. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
| @@ -364,7 +362,7 @@ def main(argv=sys.argv[1:]): | |||
| "--overwrite_cmake_configs", | |||
There was a problem hiding this comment.
we may want to rename this argument since it doesn't write cmake configs anymore, though it does control writing of dsv files
There was a problem hiding this comment.
Technically those are cmake config files (files ending .in which are supposed to be consumed by cmake's configure)
There was a problem hiding this comment.
This script is used when releasing packages in Harmonic and Ionic, so I think we should detect if a package belongs to Jetty and just skip generating the cmake.in files. Alternatively, we could make a branch in gz_vendor that tracks the version of Gazebo the script corresponds to, but that would require changes in our release.py script. I'd vote for the first approach.
|
Can you also add support for python bindings by removing gz_vendor/create_gz_vendor_pkg/create_vendor_package.py Lines 328 to 329 in 9e922b0 |
Per gazebo-tooling/release-tools#1244, version numbers have been removed from package names in Jetty (except for gz-tools2). Support for this change has been prototyped in the draft pull requests listed in gazebosim/gz-jetty#38 and are applied to the template here.
The unversioned
{cmake_pkg_name(pkg_name_no_version)}-config.cmake.inand{vendor_name}-extras.cmake.incmake files are no longer needed since the upstream packages provided unversioned cmake files.