Skip to content

ci: run cppcheck, cpplint, doxygen on noble #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Part of gazebo-tooling/release-tools#1222

Summary

Jammy isn't officially supported for Ionic, so move linters to use Noble, starting with cppcheck and cpplint.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Part of gazebo-tooling/release-tools#1222.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (4c0ba4b) to head (71463ab).
Report is 4 commits behind head on gz-plugin3.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-plugin3     #172   +/-   ##
===========================================
  Coverage       98.72%   98.72%           
===========================================
  Files              23       23           
  Lines             785      785           
===========================================
  Hits              775      775           
  Misses             10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scpeters scpeters marked this pull request as ready for review April 26, 2025 20:41
@scpeters scpeters requested a review from ahcorde as a code owner April 26, 2025 20:41
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 28, 2025
@scpeters scpeters merged commit 61fcd15 into gz-plugin3 Apr 28, 2025
14 checks passed
@scpeters scpeters deleted the scpeters/noble_ci branch April 28, 2025 19:09
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants