Skip to content

Conversation

cmoinier
Copy link
Collaborator

Description

This PR hides the keywords when they are taking up too much space. This answers to the feature request on #1307
I have chosen the threshold to be of 4 lines of badges (which translates to 7 lines of text for the component doing the hiding job), but this is of course debatable.

Architectural changes

No changes

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

How to test

Import a record with many keywords, such as the BD TOPO. Check that over record with less keywords don't have the section hidden.

@cmoinier cmoinier added the feature request A suggestion or request (not a proposal) label Aug 21, 2025
Copy link
Contributor

github-actions bot commented Aug 21, 2025

Affected libs:
ui-elements,feature-notifications,feature-editor,feature-search,feature-router,feature-map,feature-record,feature-catalog,ui-catalog,ui-search

Affected apps:
metadata-editor,demo,datahub,webcomponents,map-viewer,search

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Aug 21, 2025

Coverage Status

coverage: 83.598% (+1.0%) from 82.598%
when pulling 80f5ed3 on hide-keywords-when-many
into b8a597a on main.

Copy link
Contributor

github-actions bot commented Aug 21, 2025

📷 Screenshots are here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A suggestion or request (not a proposal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants