Skip to content

Fix concatenation of query params to WFS 2.0.0 url when it already contains params #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix concatenation of query params to WFS 2.0.0 url when it already contains params #944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions owslib/feature/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from urllib.parse import urlencode
from owslib.crs import Crs
from owslib.util import Authentication
from owslib.util import Authentication, build_get_url
from owslib.feature.schema import get_schema
from owslib.feature.postrequest import PostRequest_1_1_0, PostRequest_2_0_0

Expand Down Expand Up @@ -209,7 +209,6 @@ def getGETGetFeatureRequest(
if m.get("type").lower() == method.lower()
)
)
base_url = base_url if base_url.endswith("?") else base_url + "?"

request = {"service": "WFS", "version": self.version, "request": "GetFeature"}

Expand Down Expand Up @@ -248,9 +247,7 @@ def getGETGetFeatureRequest(
if outputFormat is not None:
request["outputFormat"] = outputFormat

data = urlencode(request, doseq=True)

return base_url + data
return build_get_url(base_url, request)

def getPOSTGetFeatureRequest(
self,
Expand Down