Skip to content

Commit cb8da37

Browse files
committed
qrpred is not defined in GLM v1.9
1 parent a201338 commit cb8da37

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

src/linpred.jl

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@ leverage_weights(p::LinPred, wt::AbstractVector) = sqrt.(1 .- leverage(p, wt))
5656
###### DensePredQR
5757
##########################################
5858

59-
@static if get_pkg_version(GLM) < v"1.9"
59+
@static if get_pkg_version(GLM) < v"1.10"
6060
@warn(
6161
"GLM.DensePredQR(X::AbstractMatrix, pivot::Bool=true) is not defined, " *
6262
"fallback to unpivoted RobustModels.DensePredQR definition. " *
63-
"To use pivoted QR, GLM version should be greater than or equal to v1.9."
63+
"To use pivoted QR, GLM version should be greater than or equal to v1.10."
6464
)
6565

6666
using LinearAlgebra: QRCompactWY, QRPivoted, Diagonal, qr!, qr
@@ -176,14 +176,8 @@ leverage_weights(p::LinPred, wt::AbstractVector) = sqrt.(1 .- leverage(p, wt))
176176
return p
177177
end
178178

179-
180-
## Use DensePredQR from GLM
181-
elseif get_pkg_version(GLM) < v"1.10"
182-
using GLM: DensePredQR
183-
# GLM.DensePredQR(X::AbstractMatrix, pivot::Bool) is not defined
184-
qrpred(X::AbstractMatrix, pivot::Bool=false) = DensePredQR(X)
185-
186179
else
180+
## Use DensePredQR from GLM
187181
using GLM: DensePredQR
188182
# GLM.DensePredQR(X::AbstractMatrix, pivot::Bool) is defined in #master
189183
import GLM: qrpred

0 commit comments

Comments
 (0)