Make the compacted hal acceleration structure inherit a label from the base BLAS. #8103
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vecvec
force-pushed
the
blas-compact-inherit-label
branch
from
900523d to
b276e21
Compare
JMS55
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Requested by @JMS55 on matrix. Previously, if a BLAS was created and then compacted, the wgpu-core compacted BLAS would inherit the same label (plus "compacted" added to the end), but not the hal acceleration structure. This PR sends the label down to the hal BLAS too.
Testing
None - just adds a label, which can't really be tested.
Squash or Rebase?
Squash
Checklist
cargo fmt.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.