Add mesh shading info to naga IR #8104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 tasks
|
I'm unsure why the MSRV minimal versions thing is failing, it doesn't look related to this PR since it happens in another crate and this PR doesn't touch anything cargo. |
|
Should be fixed with #8112, thanks @andyleiserson! |
jimblandy
reviewed
Aug 20, 2025
| @@ -966,6 +984,7 @@ pub enum Binding { | |||
| /// Optional `blend_src` index used for dual source blending. | |||
| /// See <https://www.w3.org/TR/WGSL/#attribute-blend_src> | |||
| blend_src: Option<u32>, | |||
| per_primitive: bool, | |||
There was a problem hiding this comment.
Could we have some docs for this? The Location variant's docs talk about passing values from the vertex stage to the fragment stage; we should make sure the story told here makes sense for readers working on mesh shaders too.
There was a problem hiding this comment.
I've tried to write some docs. Let me know if you have further comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Mostly split off from #7390
Works towards #7197
Description
This PR adds mesh shading info to naga IR so that parsers and writers have an interface to use.
Testing
No testing yet (coming in later PRs, the code here has been tested in #7390)
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.