Skip to content

Update shader bencher to share some logic with snapshots #8108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

SupaMaggie70Incorporated
Copy link
Contributor

@SupaMaggie70Incorporated SupaMaggie70Incorporated commented Aug 15, 2025

Connections
This is to address test failings in #7930 due to not respecting supported backends. In fact, its pulled directly from the last few commits there.

Description
Previously, the shader bencher was using snapshot shaders but not respecting their options, such as which backends they should be tested against. As a result, in #7930, a mesh shader test shader that only can be written to SPIRV was causing the shader bencher to fail. I have updated the shader bencher and snapshots to share more logic.

See this comment

Testing
The change is to testing itself. I have verified that the bencher still fails on bad shader inputs, and that it ignores my mesh shader as it is supposed to.

Squash or Rebase?

Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@cwfitzgerald cwfitzgerald self-assigned this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants