[naga] Introduce KeywordSet and CaseInsensitiveKeywordSet.
#8136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpreid
force-pushed
the
naga-kwset
branch
2 times, most recently
from
9751aaf to
2950bbd
Compare
cwfitzgerald
requested changes
Aug 27, 2025
These new data structure types provide a narrow, public API for the tables `naga::proc::Namer` requires, fixing <gfx-rs#7552>. Additionally, they use `naga::FastHashSet` instead of `hashbrown::HashSet`, which may be faster (benchmarks not conclusive but not worse). I also removed `RacyLock::get()` because types which implement `Deref` generically should not also have methods, to avoid name conflicts.
cwfitzgerald
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #7552.
Description
These new data structure types provide a narrow, public API for the tables
naga::proc::Namerrequires, fixing #7552.Additionally, they use
naga::FastHashSetinstead ofhashbrown::HashSet, which may be faster (benchmarks not conclusive but not worse).Testing
cargo xtask testcargo bench --bench wgpu-benchmark -- back/Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.