Merge dot products in PIPECG #1908
Open
+174
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
pratikvn
reviewed
Aug 7, 2025
core/solver/pipe_cg.cpp
Outdated
Comment on lines
125
to
127
| auto* w = w_unique.get(); | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| auto* w = w_unique.get(); | |
| auto* w = w_unique.get(); | |
core/solver/pipe_cg.cpp
Outdated
| // GKO_SOLVER_VECTOR(r, dense_b); | ||
| // GKO_SOLVER_VECTOR(w, dense_b); | ||
| // into rw that we later slice for efficient dot product computation | ||
| auto stride = dense_b->get_stride(); |
There was a problem hiding this comment.
nit: make it clear that this is b_stride
core/solver/pipe_cg.cpp
Outdated
| // m = preconditioner * w | ||
| this->get_preconditioner()->apply(w, m); | ||
| // n = A * m | ||
| this->get_system_matrix()->apply(m, n); | ||
| // TODO: merge these two dot products: | ||
| // merged dot products | ||
| // rho = dot(r, z) |
There was a problem hiding this comment.
Suggested change
| // rho = dot(r, z) | |
| // rho = dot(r, z1) |
core/solver/pipe_cg.cpp
Outdated
| // rho = dot(r, z) | ||
| r->compute_conj_dot(z, rho, reduction_tmp); | ||
| // delta = dot(w, z) |
There was a problem hiding this comment.
Suggested change
| // delta = dot(w, z) | |
| // delta = dot(w, z2) |
gojakuch
force-pushed
the
feat/pipe-cg-dotmerge
branch
2 times, most recently
from
f24265c to
23a35a3
Compare
|
Addressed the suggestions yesterday, rebased now. |
gojakuch
force-pushed
the
feat/pipe-cg-dotmerge
branch
from
23a35a3 to
4c7a3d5
Compare
gojakuch
added
1:ST:ready-for-review
gojakuch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on the work done in PIPECG by making it fulfill its initial purpose of reducing the number of dot products in the algorithm by merging them into a singe dot operation.