Skip to content

feat: add direct donate button #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jul 18, 2024
Merged

feat: add direct donate button #3553

merged 27 commits into from
Jul 18, 2024

Conversation

thelostone-mc
Copy link
Contributor

@thelostone-mc thelostone-mc commented Jul 11, 2024 •
edited by bhargavaparoksham
Loading

Fixes: BLU-77
Fixes: BLU-78

Testing:

  1. Should see donation button on project page (Home -> Explore Projects -> Project) when on sepolia. Please use explorer staging link to test.
  2. When on a chain other than sepolia should not see the donation button.
  3. Should show error states when insufficient balance or if "0" or empty Donation amount.
  4. Should be able to donate both using ETH & ERC20 token.

@vercel Vercel
Copy link

vercel bot commented Jul 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 2:18pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 2:18pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 2:18pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 2:18pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 2:18pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 2:18pm

@thelostone-mc thelostone-mc changed the title wip feat: add direct donate button Jul 11, 2024
@katgitcoin
Copy link

When I try to donate 0.001 ETH, the donation is put through as 1 ETH. Do we handle donation values smaller than 1?

@MasterHW MasterHW merged commit 1041516 into main Jul 18, 2024
14 checks passed
@MasterHW MasterHW deleted the direct-allocate branch July 18, 2024 19:37
thelostone-mc added a commit that referenced this pull request Jul 19, 2024
@thelostone-mc
Revert "feat: add direct donate button (#3553)"
ef12813 
This reverts commit 1041516.
@bhargavaparoksham bhargavaparoksham mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@bhargavaparoksham bhargavaparoksham bhargavaparoksham approved these changes

@MasterHW MasterHW MasterHW approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thelostone-mc @katgitcoin @bhargavaparoksham @MasterHW