Skip to content

Add Public Profile Button #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Add Public Profile Button #3554

merged 2 commits into from
Jul 11, 2024

Conversation

0xKurt
Copy link
Contributor

@0xKurt 0xKurt commented Jul 11, 2024

This PR adds a View Public Profile button in builder to quickly find the profiles page on explorer

image

@0xKurt 0xKurt requested review from a team as code owners July 11, 2024 08:20
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:10am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:10am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:10am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:10am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:10am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 9:10am

Copy link
Contributor

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xKurt is it possible to both copy the link to the clipboard and navigate to the public profile? as a user, if I see the link icon, I expect that the link is copied to my clipboard.

if it's not possible to do both actions, then I would get rid of the icon and change the copy to "view public profile"

@0xKurt
Copy link
Contributor Author

0xKurt commented Jul 11, 2024

@0xKurt is it possible to both copy the link to the clipboard and navigate to the public profile? as a user, if I see the link icon, I expect that the link is copied to my clipboard.

if it's not possible to do both actions, then I would get rid of the icon and change the copy to "view public profile"

changed to View Public Profile

@thelostone-mc thelostone-mc merged commit 89239c4 into main Jul 11, 2024
14 checks passed
@thelostone-mc thelostone-mc deleted the view-public-profile branch July 11, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants