Skip to content

fix builder round dates #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix builder round dates #3562

merged 1 commit into from
Jul 25, 2024

Conversation

MasterHW
Copy link
Contributor

Fixes: #3561

Description

logic seemed to be reversed on setting round times based on the round being direct grant or not. flipped it, and now non-direct grants rounds are showing correct round times.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@MasterHW MasterHW requested review from a team as code owners July 24, 2024 18:01
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 6:02pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 6:02pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 6:02pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 6:02pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 6:02pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 6:02pm

Copy link
Contributor

@hussmartinez hussmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc thelostone-mc merged commit 3e4563d into main Jul 25, 2024
14 checks passed
@thelostone-mc thelostone-mc deleted the fix-builder-dates branch July 25, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder - Application & Round dates appearing the same
3 participants