Skip to content

fix: wrong project added to cart bug #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024
Merged

fix: wrong project added to cart bug #3594

merged 2 commits into from
Aug 8, 2024

Conversation

bhargavaparoksham
Copy link
Contributor

Fixes: PAR-217

Description

Fixes wrong project added to cart bug & updates sidebar ui in project page to be more descriptive.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@bhargavaparoksham bhargavaparoksham requested review from a team as code owners August 8, 2024 15:50
Copy link

linear bot commented Aug 8, 2024

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 3:50pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 3:50pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 3:50pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 3:50pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 3:50pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 3:50pm

Copy link
Contributor

@hussmartinez hussmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hussmartinez hussmartinez merged commit e42c0d7 into main Aug 8, 2024
14 checks passed
@hussmartinez hussmartinez deleted the fix-project-issue branch August 8, 2024 20:08
Copy link

sentry-io bot commented Aug 12, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to fetch value(chrome-extension://aflkmfhebedbjioipglgcb... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants