Skip to content

Conversation

Giom-V
Copy link
Collaborator

@Giom-V Giom-V commented Sep 12, 2024

  • Limit the check to new .ipynb files
  • When a file is in a sub-folder, accept it if there's a link to the file in a sub-folder's README

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Giom-V Giom-V marked this pull request as ready for review September 12, 2024 16:34
@Giom-V Giom-V requested a review from MarkDaoust September 12, 2024 16:37
markmcd
markmcd previously approved these changes Sep 13, 2024
@Giom-V Giom-V marked this pull request as draft September 13, 2024 09:48
@Giom-V Giom-V marked this pull request as draft September 13, 2024 09:48
@Giom-V Giom-V marked this pull request as ready for review September 13, 2024 13:20
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Sep 13, 2024
@Giom-V Giom-V removed the request for review from MarkDaoust September 16, 2024 09:36
@Giom-V Giom-V merged commit b12f60b into google-gemini:main Sep 16, 2024
3 checks passed
@Giom-V Giom-V deleted the readme-links-in-current-folder branch September 16, 2024 09:37
Vruddhi18 pushed a commit to Vruddhi18/cookbook that referenced this pull request Dec 2, 2024
* Accept if a file is linked in it's folder's README
* Using tj-actions/changed-files@ to detect new files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:examples Issues/PR referencing examples folder status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants