-
Notifications
You must be signed in to change notification settings - Fork 2k
Improving utils using the new response.part accessor #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Giom-V, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the image handling utilities within the Image_out.ipynb quickstart by upgrading the google-genai library and adopting its new response.parts accessor. This change simplifies the code for displaying and saving image outputs from generative models, improving readability and maintainability. Additionally, it updates a billing-related warning message for better clarity.
Highlights
- Dependency Update: The google-genai library minimum version has been upgraded from 1.5.0 to 1.32.0 to enable the use of the new response.parts accessor.
- Code Simplification: The display_response and save_image utility functions in the notebook have been refactored to leverage the response.parts accessor and part.as_image() method, streamlining the process of extracting and handling image data from model responses.
- User Guidance Improvement: The warning message related to image generation billing has been updated to provide clearer instructions, including a direct link to enable billing, and the background color of the warning box has been changed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the utility functions in the Image_out.ipynb
notebook by adopting the new response.parts
accessor, which simplifies the code. The changes also include updating the required SDK version, fixing a broken link, and clarifying the pricing information. My review points out an inconsistency in one of the updated functions where the old accessor is still being used, which I've flagged for correction.
No description provided.