Updating the banner #921
Updating the banner #921
Conversation
github-actions
bot
added
the
status:awaiting review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Giom-V, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing user guidance within the quickstarts-js project, specifically addressing the image generation feature. The primary goal is to clarify billing requirements and improve the setup instructions for users. This involves updating the visual presentation and content of a key warning banner, alongside a minor refinement to a setup heading.
Highlights
- Visual Update to Warning Banner: The warning banner's background color has been updated from a pinkish tone to a more prominent yellow, enhancing its visibility.
- Improved Billing Guidance in Banner: The text within the image generation warning banner has been revised to explicitly guide users on enabling billing, including a direct link and a visual cue (an image) for clarity.
- Documentation Clarity: A minor textual refinement was made in the 'Setup' section, updating a heading for better readability and precision regarding API key setup.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates a banner and a heading in the Image_out.js file. My review includes a fix for a typo in an HTML target attribute, a suggestion to modernize the HTML by replacing deprecated tags with CSS, and a correction to a heading to align with the repository's style guide regarding sentence case and grammar.
| <td bgcolor="#f5949e"> | ||
| <h3><font color=black>Image generation is a paid-only feature and won't work if you are on the free tier. Check the <a href="https://ai.google.dev/pricing#gemini-2.5-flash-image-preview"><font color='#217bfe'>pricing</font></a> page for more details.</font></h3> | ||
| <td bgcolor="#ffe680"> | ||
| <h3><font color=black>After a few free tries, you will need <a href="https://ai.google.dev/gemini-api/docs/billing#enable-cloud-billing" taget="_blank">billing</a> enabled to use image generation. Click on the |
There was a problem hiding this comment.
There is a typo in the <a> tag. The attribute taget should be target. This typo will prevent the link from opening in a new tab as intended.
<h3><font color=black>After a few free tries, you will need <a href="https://ai.google.dev/gemini-api/docs/billing#enable-cloud-billing" target="_blank">billing</a> enabled to use image generation. Click on the | <table> | ||
| <tr> | ||
| <!-- Emoji --> | ||
| <td bgcolor="#f5949e"> | ||
| <td bgcolor="#ffe680"> | ||
| <font size=30>⚠️</font> | ||
| </td> | ||
| <!-- Text Content Cell --> | ||
| <td bgcolor="#f5949e"> | ||
| <h3><font color=black>Image generation is a paid-only feature and won't work if you are on the free tier. Check the <a href="https://ai.google.dev/pricing#gemini-2.5-flash-image-preview"><font color='#217bfe'>pricing</font></a> page for more details.</font></h3> | ||
| <td bgcolor="#ffe680"> | ||
| <h3><font color=black>After a few free tries, you will need <a href="https://ai.google.dev/gemini-api/docs/billing#enable-cloud-billing" taget="_blank">billing</a> enabled to use image generation. Click on the | ||
| <img src="https://i.postimg.cc/pX6FQwjz/key-off-24dp-E3-E3-E3-FILL0-wght400-GRAD0-opsz24.png" style="margin:0px 0px !important;" height="18px" width="18px" /> | ||
| button in the top right corner to select a cloud project with billing.</font></h3> | ||
| </td> | ||
| </tr> | ||
| </table> |
There was a problem hiding this comment.
The HTML in this banner uses deprecated tags (<font>) and attributes (bgcolor). For better maintainability and adherence to modern web standards, it's recommended to use CSS for styling. Consider replacing bgcolor with the background-color CSS property and <font> tags with properties like font-size and color within a <style> tag or an external stylesheet.
| ### Install SDK and set-up the client | ||
|
|
||
| ### API Key Configuration | ||
| ### Install SDK and set-up the client with the API key |
There was a problem hiding this comment.
This heading can be improved to align with the style guide and common grammar:
- The style guide requires sentence case for headings.1
- 'set up' (verb) is more appropriate here than 'set-up' (noun/adjective).
### Install SDK and set up the client with the API keyStyle Guide References
Footnotes
No description provided.