Google Sans Code: Version 6.001 added #9762
Conversation
Taken from the upstream repo https://github.com/googlefonts/googlesans-code at commit googlefonts/googlesans-code@edcd56e.
MariannaPaszkowska
added
I Font Upgrade
I Small Fix
|
link to the issue in the upstream repo: googlefonts/googlesans-code#23 |
FontSpector reportfontspector version: 1.4.0 Check results[15] ofl/googlesanscode/GoogleSansCode[wght].ttf🔥 FAIL Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
|
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 6.001 [code: version-not-detected]
[1] ofl/googlesanscode/article/ARTICLE.en_us.html
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
[1] ofl/googlesanscode/METADATA.pb
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[16] ofl/googlesanscode/GoogleSansCode-Italic[wght].ttf
🔥 FAIL Combined length of family and style must not exceed 32 characters. (name/family_and_style_max_length)
- 🔥 FAIL Variable font instance name 'Google Sans Code ExtraBold Italic' formed by space-separated concatenation of font family name (nameID FAMILY_NAME) and instance subfamily nameID ExtraBold Italic exceeds 32 characters.
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
🔥 FAIL Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
- 🔥 FAIL Failed language shaping:
| Message | Languages |
|---|---|
| Mandatory orthography codepoints: | * bm_Latn (Bambara) |
| The following base characters are missing from the font: Ɛ, Ɔ, ɲ, Ɲ, ɛ, ɔ | |
| Mandatory orthography codepoints: | * dyu_Latn (Dyula) |
| The following base characters are missing from the font: ɛ, ɔ, ɲ, Ɛ, Ɲ, Ɔ | |
| Mandatory orthography codepoints: | * tw_akuapem_Latn (Akuapem Twi) |
| The following base characters are missing from the font: ɔ, Ɛ, ɛ, Ɔ | |
| Mandatory orthography codepoints: | * yo_Latn (Yoruba) |
| Shaper didn't attach gravecomb to m when shaping the text 'm̀' | |
| Shaper didn't attach gravecomb to M when shaping the text 'M̀' | |
| Mandatory orthography codepoints: | * fat_Latn (Fanti) |
| The following base characters are missing from the font: ɔ, Ɔ, Ɛ, ɛ |
⚠️ WARN Warning language shaping:
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: ŧ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ŧ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * lt_Latn (Lithuanian) |
| Shaper didn't attach tildecomb to M when shaping the text 'M̃' | |
| Shaper didn't attach acutecomb to iogonek when shaping the text 'į́' | |
| Shaper didn't attach uni0307 to iogonek when shaping the text 'į̇́' | |
| Shaper didn't attach acutecomb to uni0307 when shaping the text 'į̇́' | |
| Shaper didn't attach tildecomb to iogonek when shaping the text 'į̃' | |
| Shaper didn't attach uni0307 to iogonek when shaping the text 'į̇̃' | |
| Shaper didn't attach tildecomb to uni0307 when shaping the text 'į̇̃' | |
| Shaper didn't attach tildecomb to m when shaping the text 'm̃' | |
| Auxiliary orthography codepoints: | * ig_Latn (Igbo) |
| The following auxiliary characters are missing from the font: ɛ | |
| The following auxiliary characters are missing from the font: Ɛ | |
| The following auxiliary characters are missing from the font: ɵ | |
| The following auxiliary characters are missing from the font: Ɵ | |
| Shaper didn't attach acutecomb to uni1ECB when shaping the text 'ị́' | |
| Shaper didn't attach gravecomb to uni1ECB when shaping the text 'ị̀' | |
| Shaper didn't attach gravecomb to m when shaping the text 'm̀' | |
| Shaper didn't attach gravecomb to M when shaping the text 'M̀' |
⚠️ WARN Checking correctness of monospaced metadata. (opentype/monospace)
⚠️ WARN The OpenType spec recommends at https://learn.microsoft.com/en-us/typography/opentype/spec/recom#hhea-table that hhea.numberOfHMetrics be set to 3 but this font has 635 instead.
Please read hhea.numberOfHMetrics not correct for monospace fonttools/fonttools#3014 to decide whether this makes sense for your font. [code: bad-numberOfHMetrics]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron (alt_caron)
-
⚠️ WARN Lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline] -
⚠️ WARN dcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline] -
⚠️ WARN lcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline] -
⚠️ WARN tcaron is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
-
⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
inferred from the typical amounts of contours observed in a
large collection of reference font families. The divergences
listed below may simply indicate a significantly different
design on some of your glyphs. On the other hand, some of these
may flag actual bugs in the font such as glyphs mapped to an
incorrect codepoint. Please consider reviewing the design and
codepoint assignment of these to make sure they are correct.The following glyphs do not have the recommended number of contours:
- Imacron (U+012A): found 4, expected one of: {3, 2, 6}
- Idotaccent (U+0130): found 4, expected one of: {2, 6, 3}
- Itilde (U+0128): found 4, expected one of: {2, 3, 6}
- uni1EC8 (U+1EC8): found 4, expected one of: {2, 6, 3}
- uni1ECA (U+1ECA): found 4, expected one of: {3, 6, 2}
- ijacute (unencoded): found 5, expected one of: {3, 4}
- uni2325 (U+2325): found 4, expected one of: {2} [code: contour-count]
⚠️ WARN Ensure variable fonts include an avar table. (mandatory_avar_table)
⚠️ WARN The font does not include an avar table. [code: missing-avar]
⚠️ WARN Ensure indic fonts have the Indian Rupee Sign glyph. (rupee)
⚠️ WARN Font is missing the Indian Rupee Sign glyph. Please add a glyph for Indian Rupee Sign (₹) at codepoint U+20B9. [code: missing-rupee]
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave. (typoascender_exceeds_Agrave)
⚠️ WARN OS/2.sTypoAscender value should be greater than 1998, but got 1932 instead [code: typoAscender]
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
⚠️ WARN The following separator glyphs are missing:
- U+2028
- U+2029 [code: missing-separator-glyphs]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į̂
-
į̄
-
į̀
-
į̃
-
į̌
-
į́
-
ị̂
-
ị̄
-
ị̀
... and 2 othersThe dot of soft dotted characters should disappear in other cases, for example: -
į̩̉
-
į̩̂
-
į̩̄
-
į̩̀
-
į̩̇
-
į̩̊
-
į̩̋
-
į̩̒
-
į̩̃
... and 253 others [code: soft-dotted]
⚠️ WARN Are there any misaligned on-curve points? (outline_alignment_miss)
⚠️ WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
-
- bracketleft (U+005B): X=1159,Y=1431 (should be at cap-height 1432?)
-
- bracketleft (U+005B): X=673,Y=1431 (should be at cap-height 1432?)
-
- bracketright (U+005D): X=847,Y=1431 (should be at cap-height 1432?)
-
- bracketright (U+005D): X=361,Y=1431 (should be at cap-height 1432?)
-
- i (U+0069): X=559,Y=1431 (should be at cap-height 1432?)
-
- i (U+0069): X=863,Y=1430 (should be at cap-height 1432?)
-
- j (U+006A): X=715,Y=1431 (should be at cap-height 1432?)
-
- j (U+006A): X=1019,Y=1430 (should be at cap-height 1432?)
-
- Atilde (U+00C3): X=508.5,Y=1933.5 (should be at ascender 1932?)
... and 39 others [code: found-misalignments]
- Atilde (U+00C3): X=508.5,Y=1933.5 (should be at ascender 1932?)
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Google Sans Code" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 6.001 [code: version-not-detected]
[4] ofl/googlesanscode
⚠️ WARN Validate size, and resolution of article images,
and ensure article page has minimum length and includes visual assets. (googlefonts/article/images)
⚠️ WARN Article page lacks visual assets. [code: missing-visual-asset]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/googlesanscode/GoogleSansCode[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
Or you can add the above codepoints to one of the subsets supported by the font: adlam, canadian-aboriginal, cherokee, latin, latin-ext, math, menu, old-permic, symbols, symbols2, syriac, vietnamese [code: unreachable-subsetting]
⚠️ WARN ofl/googlesanscode/GoogleSansCode-Italic[wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
Or you can add the above codepoints to one of the subsets supported by the font: adlam, canadian-aboriginal, cherokee, latin, latin-ext, math, menu, old-permic, symbols, symbols2, syriac, vietnamese [code: unreachable-subsetting]
ℹ️ INFO METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
-
ℹ️ INFO The subset 'latin-ext' is listed in production metadata, but only 0.15% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'adlam' is listed in production metadata, but only 0.31% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'syriac' is listed in production metadata, but only 0.15% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'math' is listed in production metadata, but only 0.05% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'canadian-aboriginal' is listed in production metadata, but only 0.01% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'cherokee' is listed in production metadata, but only 0.04% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'old-permic' is listed in production metadata, but only 0.10% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'symbols' is listed in production metadata, but only 0.02% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
-
ℹ️ INFO None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
wght-ital: 2 [code: summary]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 4 | 31 | 18 | 241 | 59 |
| 1% | 9% | 5% | 72% | 18% |
|
will close #9763 |
|
Note: |
|
@simoncozens PTAL :) |
Taken from the upstream repo https://github.com/googlefonts/googlesans-code at commit googlefonts/googlesans-code@edcd56e.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS