abi: support Siena product line #167
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the "Siena" product line, which, as per the VCEK and KDS interface spec (rev 1.0), is widely identical to the Genoa product line. Furthermore, it aligns the parsing of the model line with the specification by only referring to the extended model ID for deriving the product name from the CPUID return value, which is what Table 4 of the aforementioned specification suggests.
This has been tested on a Siena machine with the following example program:
Before this patch, this would return:
After the patch, it correctly selects the "Genoa" product line: