Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the ops for lowering
key_switch_inner
is to partition the coefficients of a polynomial. This op will eventually lower to a combination ofThis actually kind of makes me think we don't need a dedicated op at all. We can just lower directly to the three ops this will lower to. Is there an advantage to having this intermediate op? I suppose that would depend on how other methods of implementing keyswitch might differ with this one.
Part of #2157
CC @crockea @AlexanderViand