Feat: implement rust sdk (counter and list) #4247

lacroixthomas · 2025-08-13T23:18:39Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:

Add unit test on the rust sdk (code + Makefile)
Integrate the beta for the rust sdk
Add conformance test for counter and list (beta)

Which issue(s) this PR fixes:

Closes #3644

Special notes for your reviewer:
I'm new to rust, this will need a proper review 😄

lacroixthomas · 2025-08-13T23:26:42Z

test/sdk/rust/src/main.rs

+    if feature_gates.contains("CountsAndLists=true") {
+        run_counts_and_lists_features(sdk.beta().clone())?;
+    }


It was like that for the profile part, but I wonder if we can retrieve that in a different way, it feels hacky to have an hardcoded string for the feature gates (same for the async)

lacroixthomas · 2025-08-13T23:31:53Z

@Jake-Shadle @MiniaczQ
Sorry about that, I've seen that you were tagged on the ticket and that you have rust experiences ?
If you have some time for review, I'm new to rust, so don't hesitate if you see anything wrong 😄

agones-bot · 2025-08-14T04:19:49Z

Build Failed 😭

Build Id: 22c397bf-174e-441e-8a13-c04c1bf43021

Status: TIMEOUT

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-08-15T17:43:37Z

Build Succeeded 🥳

Build Id: a6f71218-b5cc-4b89-9130-fdd23b6c44aa

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-2447197
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-2447197
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-2447197-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-2447197
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-2447197
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-2447197
Linux C++ SDK (build): agonessdk-1.52.0-dev-2447197-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-2447197.zip

A preview of the website (the last 30 builds are retained):

https://2447197-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4247/head:pr_4247 && git checkout pr_4247
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-2447197

agones-bot · 2025-08-15T17:50:34Z

Build Failed 😭

Build Id: a6b6abc8-f2e4-42e8-85a0-840d7b4b61e3

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-08-15T17:51:37Z

/gcbrun

agones-bot · 2025-08-15T19:18:11Z

Build Succeeded 🥳

Build Id: 1a429709-cec1-48c4-b8f8-b63c20b85c5b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-ac1da39
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-ac1da39
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-ac1da39-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-ac1da39
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-ac1da39
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-ac1da39
Linux C++ SDK (build): agonessdk-1.52.0-dev-ac1da39-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-ac1da39.zip

A preview of the website (the last 30 builds are retained):

https://ac1da39-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4247/head:pr_4247 && git checkout pr_4247
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-ac1da39

agones-bot · 2025-08-15T20:13:13Z

Build Succeeded 🥳

Build Id: 8620f7b4-b29a-4871-aaf2-42c7a2497ea3

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-47905c7
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-47905c7
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-47905c7-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-47905c7
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-47905c7
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-47905c7
Linux C++ SDK (build): agonessdk-1.52.0-dev-47905c7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-47905c7.zip

A preview of the website (the last 30 builds are retained):

https://47905c7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4247/head:pr_4247 && git checkout pr_4247
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-47905c7

lacroixthomas · 2025-08-15T20:23:17Z

/gcbrun

agones-bot · 2025-08-15T21:55:54Z

Build Failed 😭

Build Id: b77f2050-fce7-4757-82d5-1f1783dba06b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-08-15T22:05:26Z

Gonna double check the logs in GCP, but might be the issue fixed by this PR: #4224

/gcbrun

agones-bot · 2025-08-15T22:39:02Z

Build Failed 😭

Build Id: fefdd5ad-177b-4c5e-ac06-15a86ffe2410

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-08-16T00:57:07Z

Build Succeeded 🥳

Build Id: ecf81ab0-ed5b-476d-92f8-e1b01482e12a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-71a1568-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-71a1568
Linux C++ SDK (build): agonessdk-1.52.0-dev-71a1568-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-71a1568.zip

A preview of the website (the last 30 builds are retained):

https://71a1568-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4247/head:pr_4247 && git checkout pr_4247
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-71a1568

lacroixthomas · 2025-08-16T01:02:44Z

/gcbrun

agones-bot · 2025-08-16T01:12:36Z

Build Failed 😭

Build Id: 61f96e87-14d9-4932-b6c7-055b0f1627a8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-08-16T01:25:11Z

And now the unit tests are failing on metrics randomely 😭

/gcbrun

agones-bot · 2025-08-16T02:29:47Z

Build Succeeded 🥳

Build Id: 4a16bd5f-da93-47fd-a555-51ca7dd672e6

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-71a1568-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-71a1568
Linux C++ SDK (build): agonessdk-1.52.0-dev-71a1568-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-71a1568.zip

A preview of the website (the last 30 builds are retained):

https://71a1568-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4247/head:pr_4247 && git checkout pr_4247
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-71a1568

lacroixthomas · 2025-08-16T02:32:45Z

/gcbrun

agones-bot · 2025-08-16T03:27:54Z

Build Succeeded 🥳

Build Id: 8b3a4eff-e98c-4104-afb3-cf6631f588cc

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-71a1568-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-71a1568
Linux C++ SDK (build): agonessdk-1.52.0-dev-71a1568-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-71a1568.zip

A preview of the website (the last 30 builds are retained):

https://71a1568-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4247/head:pr_4247 && git checkout pr_4247
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-71a1568

lacroixthomas · 2025-08-16T21:42:39Z

/gcbrun

agones-bot · 2025-08-16T22:44:15Z

Build Succeeded 🥳

Build Id: befe5480-f030-46d1-a261-cb9012171359

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-71a1568-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-71a1568
Linux C++ SDK (build): agonessdk-1.52.0-dev-71a1568-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-71a1568.zip

A preview of the website (the last 30 builds are retained):

https://71a1568-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4247/head:pr_4247 && git checkout pr_4247
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-71a1568

lacroixthomas · 2025-08-16T23:02:27Z

/gcbrun

agones-bot · 2025-08-16T23:57:12Z

Build Succeeded 🥳

Build Id: 42d5f4c2-13d1-4694-809f-1c362c5b37c3

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-71a1568-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-71a1568
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-71a1568
Linux C++ SDK (build): agonessdk-1.52.0-dev-71a1568-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-71a1568.zip

A preview of the website (the last 30 builds are retained):

https://71a1568-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4247/head:pr_4247 && git checkout pr_4247
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-71a1568

lacroixthomas · 2025-08-17T00:18:08Z

I'll create another issue + PR with the fix of the flaky test around the Step 25: submit-upgrade-test-cloud-build, it seems to be working well !
Otherwise it's ready for review, as I was saying on the description, I'm still new to rust (only theory learning so far, it's my first rust contribution ever), don't hesitate if there is anything that doesn't seems correct 😄
I'm more than happy to have feedbacks

agones-bot · 2025-08-24T23:25:19Z

Build Failed 😭

Build Id: 1403ae8d-b6fc-4c9d-b201-e7498e4720a1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas added 4 commits August 13, 2025 17:41

feat: implement the beta sdk in rust

e8b4052

feat: add unit tests for both alpha and beta

17fdbdb

feat: add rust unit test within the pipeline

11346fa

feat: add conformance tests

c94098e

github-actions bot added kind/feature New features for Agones size/L labels Aug 13, 2025

lacroixthomas marked this pull request as ready for review August 13, 2025 23:19

lacroixthomas commented Aug 13, 2025

View reviewed changes

lacroixthomas added 3 commits August 15, 2025 12:18

feat: update comment to match exact fn name

97bb8e1

feat: add watch permission on upgrade test

2447197

feat: add debug on helm uninstall to have more context

5eaee3e

lacroixthomas added 2 commits August 15, 2025 14:19

feat: add cluster role permission for helm uninstall

ac1da39

feat: remove debug from helm uninstall

47905c7

Merge branch 'main' into features/implement-sdk-rust

71a1568

lacroixthomas requested review from igooch, markmandel and 0xaravindh August 17, 2025 00:17

This was referenced Aug 17, 2025

[pipeline]: Missing clusterRole for Step 25 submit-upgrade-test-cloud-build #4249

Closed

Fix: Add missing permission for helm uninstall in upgrade test cleanup #4250

Merged

Merge branch 'main' into features/implement-sdk-rust

1dcf278

Feat: implement rust sdk (counter and list) #4247

Are you sure you want to change the base?

Feat: implement rust sdk (counter and list) #4247

Conversation

lacroixthomas commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lacroixthomas Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

lacroixthomas commented Aug 13, 2025

Uh oh!

agones-bot commented Aug 14, 2025

Uh oh!

agones-bot commented Aug 15, 2025

Uh oh!

agones-bot commented Aug 15, 2025

Uh oh!

lacroixthomas commented Aug 15, 2025

Uh oh!

agones-bot commented Aug 15, 2025

Uh oh!

agones-bot commented Aug 15, 2025

Uh oh!

lacroixthomas commented Aug 15, 2025

Uh oh!

agones-bot commented Aug 15, 2025

Uh oh!

lacroixthomas commented Aug 15, 2025

Uh oh!

agones-bot commented Aug 15, 2025

Uh oh!

agones-bot commented Aug 16, 2025

Uh oh!

lacroixthomas commented Aug 16, 2025

Uh oh!

agones-bot commented Aug 16, 2025

Uh oh!

lacroixthomas commented Aug 16, 2025

Uh oh!

agones-bot commented Aug 16, 2025

Uh oh!

lacroixthomas commented Aug 16, 2025

Uh oh!

agones-bot commented Aug 16, 2025

Uh oh!

lacroixthomas commented Aug 16, 2025

Uh oh!

agones-bot commented Aug 16, 2025

Uh oh!

lacroixthomas commented Aug 16, 2025

Uh oh!

agones-bot commented Aug 16, 2025

Uh oh!

lacroixthomas commented Aug 17, 2025

Uh oh!

agones-bot commented Aug 24, 2025

Uh oh!

Uh oh!

lacroixthomas commented Aug 13, 2025 •

edited

Loading