Updates the upgrade test to print any fatal error messages to the job pod termination log #4252
+235
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/cleanup
|
Build Failed 😭 Build Id: e1078bc5-96e5-4126-a0a1-4f8923b9a5f5 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
igooch
force-pushed
the
log-on-exit
branch
2 times, most recently
from
12f7096 to
e3f0ba9
Compare
… pod termination log. The package is refactored to pass back any fatal errors, cancel context, and cleanup resources on a fatal error.Additional wait timeouts are added to prevent the test from hanging.
|
Build Succeeded 🥳 Build Id: 22431f1a-4709-43ce-bb99-c935bb702b52 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
The upgrade main.go is refactored to pass back any fatal errors, cancel context, and cleanup resources on a fatal error. This way we can see exactly what Fatal error caused the test to fail. This will not include all failure scenarios (i.e. our recent failure scenario of a finalizer not being removed from the ping service), but will still make it easier to debug.
Additional wait timeouts are added to prevent the test from hanging.
Which issue(s) this PR fixes:
NA
Special notes for your reviewer: