Skip to content

fix: update deps #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: update deps #309

merged 2 commits into from
Oct 31, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Oct 31, 2024

In this PR I upgrade the dependencies to use the latest versions of the apps-query-client, sdk and ui.

We improved tree-shaking capabilities on the apps-query-client package.

Here is the build size for the code version on main:
Screenshot 2024-10-31 at 10 25 05

And with the improvements in this PR:
Screenshot 2024-10-31 at 10 23 56

This PR reduced the bundle size by a factor of 3.5x

@spaenleh spaenleh self-assigned this Oct 31, 2024
@spaenleh spaenleh added the chore Generic task or chore label Oct 31, 2024
Copy link
Contributor

@swouf swouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

However, you'll have to rebase. I merged the other PRs in the meantime. Sorry.

@spaenleh
Copy link
Member Author

@swouf No worries, thank you for the review !

@spaenleh spaenleh added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@swouf swouf added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 09b6fea Oct 31, 2024
4 checks passed
@swouf swouf deleted the update-deps branch October 31, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Generic task or chore v1.2.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants