Skip to content

Add 'failOnModifiedDerivedModuleNames' option #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

jjohannes
Copy link
Member

@jjohannes jjohannes commented Jul 9, 2025

This option is for library developers to make sure they do not use modified names of Jars without module-info and without Automatic-Module-Name.

Motivated by this discussion: APIdia-net/apidia.net#2 (comment)

TODO:

  • Tests: option on -> fail, option on but overrideModuleName() used -> no fail
  • Changelog

@koppor
Copy link
Contributor

koppor commented Jul 10, 2025

Maybe you can test this at JabRef/jabref#13521? ( ghpr checkout 13521)

@jjohannes jjohannes force-pushed the failOnModifiedDerivedModuleNames branch 3 times, most recently from 97640f2 to c5f539f Compare July 11, 2025 09:24
@jjohannes jjohannes force-pushed the failOnModifiedDerivedModuleNames branch from c5f539f to 149be7a Compare July 11, 2025 09:31
@jjohannes jjohannes merged commit 5df1c54 into main Jul 11, 2025
1 check passed
@jjohannes jjohannes deleted the failOnModifiedDerivedModuleNames branch July 11, 2025 09:52
@jjohannes
Copy link
Member Author

@koppor this is released in 1.13. Please update and add failOnModifiedDerivedModuleNames = true to your build setup to use this in the linked PR.

@koppor
Copy link
Contributor

koppor commented Jul 11, 2025

I'll do 😅

Can I remove failOnAutomaticModules = true for some more "magic"? At JabRef/jabref#13313 our contributor had difficulties adding depdencies.

@jjohannes
Copy link
Member Author

If you remove failOnAutomaticModules = true the plugin no longer informs you about Jars that miss a module-info.class. Then jpakackage will fail later - it can't work with those Jars. That's why you probably want to keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants