Skip to content

Adds a future that consumes the task budget. #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Adds a future that consumes the task budget. #730

merged 3 commits into from
Oct 14, 2024

Conversation

horned-sphere
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.97%. Comparing base (5bca951) to head (e30d088).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   50.96%   50.97%   +0.01%     
==========================================
  Files         378      378              
  Lines       32510    32517       +7     
==========================================
+ Hits        16568    16575       +7     
  Misses      15942    15942              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SirCipher
Copy link
Collaborator

@horned-sphere Tokio's consume_budget was stabilised a few months ago so we could look at reworking this now

@SirCipher
Copy link
Collaborator

Actually, maybe not as it's an async fn and doesn't return Poll.

@horned-sphere horned-sphere merged commit b06cb54 into main Oct 14, 2024
12 checks passed
@horned-sphere horned-sphere deleted the budgeted branch October 14, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants