Skip to content

Improvies debugability of event handlers. #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Nov 19, 2024
Merged

Improvies debugability of event handlers. #735

merged 22 commits into from
Nov 19, 2024

Conversation

horned-sphere
Copy link
Contributor

Adds a describe method to the HandlerAction trait that will provideda debug formatted description of the handler using information from the agent context.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 2.16777% with 1038 lines in your changes missing coverage. Please review.

Project coverage is 49.37%. Comparing base (f7018ce) to head (2410096).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
server/swimos_agent/src/event_handler/mod.rs 2.57% 189 Missing ⚠️
server/swimos_agent/src/lanes/map/mod.rs 0.00% 158 Missing ⚠️
server/swimos_agent/src/lanes/join/map/mod.rs 3.94% 73 Missing ⚠️
server/swimos_agent/src/lanes/join/value/mod.rs 3.94% 73 Missing ⚠️
server/swimos_agent/src/stores/map/mod.rs 0.00% 60 Missing ⚠️
server/swimos_agent/src/lanes/value/mod.rs 1.69% 58 Missing ⚠️
...erver/swimos_agent/src/lanes/http/lifecycle/mod.rs 0.00% 49 Missing ⚠️
server/swimos_agent/src/lanes/demand_map/mod.rs 0.00% 44 Missing ⚠️
...erver/swimos_agent/src/agent_model/downlink/mod.rs 0.00% 43 Missing ⚠️
...er/swimos_agent/src/lanes/join/map/downlink/mod.rs 0.00% 38 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   50.80%   49.37%   -1.44%     
==========================================
  Files         401      401              
  Lines       33783    34769     +986     
==========================================
+ Hits        17165    17166       +1     
- Misses      16618    17603     +985     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Base automatically changed from many-fields-fix to main November 13, 2024 16:09
@horned-sphere horned-sphere marked this pull request as ready for review November 13, 2024 16:14
@SirCipher SirCipher merged commit dc696f2 into main Nov 19, 2024
12 checks passed
@SirCipher SirCipher deleted the describe branch November 19, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants