feat(RelativeRangeDatePicker): added interactive tooltip and header #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Do we have rfc for these features? |
Yes, we do https://st.yandex-team.ru/UXRFC-509 |
korvin89
reviewed
Apr 10, 2025
| @@ -19,4 +17,8 @@ $block: '.#{variables.$ns}relative-range-date-picker-presets-doc'; | |||
| width: 100%; | |||
| } | |||
| } | |||
|
|
|||
| &__row { | |||
| vertical-align: baseline; | |||
There was a problem hiding this comment.
We don't need this style, label is aligned well without it
There was a problem hiding this comment.
It's essential to create the proper mobile view with multiline labels. It was one of the designers' request to align labels with buttons' text.
There was a problem hiding this comment.
What they think about this markup?
There was a problem hiding this comment.
Removed alignment after conversation with designers
| @@ -62,9 +65,27 @@ export function PickerForm( | |||
| size: props.size, | |||
| errorPlacement: 'inside', | |||
| }; | |||
| const {isDateUnavailable} = props; | |||
| const {isDateUnavailable, withHeader = true} = props; | |||
There was a problem hiding this comment.
It would be more consistent to use false by default
| @@ -4,5 +4,6 @@ | |||
| "\"From\" can't be after \"To\".": "\"From\" can't be after \"To\".", | |||
| "From": "From", | |||
| "To": "To", | |||
| "Apply": "Apply" | |||
| "Apply": "Apply", | |||
| "Specify the interval": "Specify the interval" | |||
There was a problem hiding this comment.
I suggest to use word Select here
korvin89
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr moves docs popover out of preset tabs since it is more related to the picker itself rather than presets. It also makes docs popover interactive: after user clicks on the buttons related input gets properly filled. The original RFC: https://st.yandex-team.ru/UXRFC-509