Skip to content

fix(DateField): can not switch segment when entering "00" #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/DateField/hooks/useBaseDateFieldState.ts
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@
const section = this.sections[sectionIndex];
let newValue = enteredKeys.current + key;

const onInputNumber = (numberValue: number) => {

Check warning on line 351 in src/components/DateField/hooks/useBaseDateFieldState.ts

View workflow job for this annotation

GitHub Actions / Verify Files

Arrow function has a complexity of 22. Maximum allowed is 20
let sectionValue = section.type === 'month' ? numberValue - 1 : numberValue;
const allowsZero = section.minValue === 0;
if (
Expand Down Expand Up @@ -384,7 +384,7 @@
this.focusNextSection();
}
} else {
enteredKeys.current = newValue === '0' ? '' : newValue;
enteredKeys.current = newValue === '0' && !allowsZero ? '' : newValue;
}
};

Expand Down
Loading