Skip to content

Remove CPCM-X library #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove CPCM-X library #1325

wants to merge 3 commits into from

Conversation

foxtran
Copy link
Contributor

@foxtran foxtran commented Jul 2, 2025

This PR removes dependency of CPCM-X library.

The reasons why:

  • often leads to failure of CI tests that may affect users too
  • no geometry optimizations
  • API is used through files

@foxtran
Copy link
Contributor Author

foxtran commented Jul 30, 2025

@thfroitzheim, can it be merged?

@thfroitzheim
Copy link
Member

While I see the stability problems with CPCM-X, it is an actively used feature of xtb and cannot just be removed. We are currently working on new solvation models, so maybe we can replace CPCM-X at some point in the future

@toxtran
Copy link

toxtran commented Jul 30, 2025

actively used feature of xtb

Do you have statistics about CPCM-X + xtb combination?

We are currently working on new solvation models,

There is GBSA solvation model which supports grafients, while CPCM-X does not.

@corinwagen
Copy link

Our team uses CPCM-X a lot for various applications, like pKa prediction and other soon-to-be-released work, so this would be quite damaging for us. It's very useful to have accurate low-cost solvation energies, even without gradients.

awvwgk
awvwgk previously approved these changes Aug 13, 2025
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this might be the right way forward for now. If this feature will be reactivated we can bring it back again from the git history.

Signed-off-by: Igor S. Gerasimov <foxtranigor@gmail.com>
Signed-off-by: Igor S. Gerasimov <foxtranigor@gmail.com>
Signed-off-by: Igor S. Gerasimov <foxtranigor@gmail.com>
@awvwgk
Copy link
Member

awvwgk commented Aug 14, 2025

Corin @corinwagen, thank you highlighting this use case, in general I would like to keep features available in xtb especially if there are active users. In case of CPCM-X there is currently no maintainer available for fixing bugs or even just creating new releases, if you are able to commit some time to (co-)maintain CPCM-X support in xtb, it would make the support of this feature much more feasible.

@corinwagen
Copy link

We'd love to help but neither @jevandezande nor I know FORTRAN, sadly

@TyBalduf
Copy link
Contributor

We also use CPCM-X for a few different applications at Schrodinger. I think we would be able to contribute towards maintaining this feature.

Does it make more sense to maintain this separate CPCM-X library or to reimplement CPCM-X into tblite? I may be misunderstanding, but it seems like it wouldn't be too extensive an addition to tblite once the ddX interface is added tblite/tblite#235

@lukaswittmann
Copy link
Member

The problem with implementing this in, e.g., tblite will be, that we fixed #1159 (and #1163). This means, that CPCM-X will not work with the new implementation (i.e., the results will likely be not usable without a rework and parameterization) and it would require us to ship two different implementations of the ddCOSMO scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants