Skip to content

Conversation

behdad
Copy link
Member

@behdad behdad commented Aug 24, 2025

@behdad behdad marked this pull request as draft August 24, 2025 21:04
@behdad behdad force-pushed the kerx-left-right-sets branch 6 times, most recently from 766b566 to d9b1913 Compare August 26, 2025 01:29
@behdad behdad requested a review from dfrg August 26, 2025 01:30
@behdad behdad force-pushed the kerx-left-right-sets branch 4 times, most recently from c211606 to 377271c Compare August 26, 2025 05:58
@behdad behdad force-pushed the kerx-left-right-sets branch from 377271c to 2625686 Compare August 26, 2025 07:51
@behdad behdad changed the title [aat] Towards adding left/right bitset caches [aat] Towards adding bitset caches Aug 26, 2025
@behdad behdad force-pushed the kerx-left-right-sets branch 2 times, most recently from de18e7c to 748fb9f Compare August 26, 2025 17:32
@behdad behdad force-pushed the kerx-left-right-sets branch from 748fb9f to 5d187e6 Compare August 26, 2025 18:55
@behdad behdad force-pushed the kerx-left-right-sets branch from 5d187e6 to 2086c11 Compare August 26, 2025 19:01
@behdad behdad marked this pull request as ready for review August 26, 2025 19:05
@behdad
Copy link
Member Author

behdad commented Aug 26, 2025

This PR is ready and shows great speedup. There are two issues to figure out:

  • With nostd, read-fonts doesn't have any U32Set. So we need to somehow disable the cache. It would be very intrusive to remove all mentions of U32Set though. So, maybe we can define it to a dummy type and make the cache always bypass.

  • Maybe move the cache creation from mod.rs into morx/kerx, so they don't have to pub(crate) so much internals.

@dfrg
Copy link
Collaborator

dfrg commented Aug 26, 2025

With nostd, read-fonts doesn't have any U32Set. So we need to somehow disable the cache. It would be very intrusive to remove all mentions of U32Set though. So, maybe we can define it to a dummy type and make the cache always bypass.

Is it worth swapping in a set digest in the no_std case?

@behdad
Copy link
Member Author

behdad commented Aug 26, 2025

Is it worth swapping in a set digest in the no_std case?

Good question. I'll investigate.

@dfrg
Copy link
Collaborator

dfrg commented Aug 26, 2025

I'll go over this in more detail when I consider how to merge the logic for kerx/kern. But generally LGTM now so let's land it.

@behdad behdad force-pushed the kerx-left-right-sets branch from 07181a8 to 2e502ba Compare August 26, 2025 22:24
@behdad behdad merged commit f436d09 into main Aug 26, 2025
2 checks passed
@behdad behdad deleted the kerx-left-right-sets branch August 26, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants