Support Postgres array migrations #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentRDC
commented
Jan 5, 2025
| @@ -164,70 +182,3 @@ marshalTest' cmp gen postgresConn = | |||
| v' `cmp` a | |||
|
|
|||
| assertBool "Hedgehog test failed" passes | |||
|
|
|||
There was a problem hiding this comment.
This test from #692 has become redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to migrate Postgres' Array types.
Note that the mechanism by which this is done is still unsafe; if trying to migrate to an array type whose elements are unsupported (i.e. array OIDs that don't exist here), then the migration will result in a runtime error rather than a compile time error.
Breaking changes would have to be made to get compile-time safety of array migrations.
Fixes #354