Avoid generating WITH clauses for 0 CTEs
#761
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API change prevents reoccurrence of haskell-beam#760.
|
This is great, thanks @isaac-uptrust ! Ideally, in this PR, we could have:
I can release this very quickly. Then, could you factor out the correct-by-construction patch into another PR? We're hoping to make a release with breaking changes relatively soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #760
I've included the direct fix, as well as a correct-by-construction API change.
The API change isn't backwards compatible, so I understand if you want to leave it out or go through a separate process for it.
Are there any tests you'd like me to write?