Skip to content

Fix codecov-action [DI-520] #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Jun 13, 2025

The C++ coverage action has been silently failing.

Updated all usages to:

  • supply a token to properly authenticate (the reason for the failure)
  • fail the step if the upload fails (to avoid the error going unreported)
  • use the latest version (consistency)

Fixes: DI-520

The C++ coverage action has been [silently failing](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/15610247637/attempts/1).

Updated all usages to:
- supply a token to properly authenticate (the reason for the failure)
- fail the step if the upload fails (to avoid the error going unreported)
- use the latest version (consistency)

Fixes: [DI-520](https://hazelcast.atlassian.net/browse/DI-520)
@JackPGreen JackPGreen self-assigned this Jun 13, 2025
@JackPGreen JackPGreen enabled auto-merge (squash) June 13, 2025 09:49
@JackPGreen JackPGreen merged commit dc76fc3 into hazelcast:master Jun 13, 2025
11 checks passed
@JackPGreen JackPGreen deleted the fix-codecov branch June 13, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants