fix: lock subscriptions #247
Conversation
every access of the Subscriptions property is now locked with a semaphore. User of the client should not access the Subscriptions, also this property is public, because they can not lock the access. Later the Subscriptions should not be public and be perhaps of type ConcurrentBag.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @SaschaBa on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
|
ok, signed the cla |
|
Excellent @SaschaBa - much appreciated. I'll fix the CLA bot and look to merge this PR soon. |
|
sorry, used language features of .net8. Will fix it. |
The project compiles for .net6 and up and so newer language features don't work.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @SaschaBa on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
primary constructor are not supported in .net6 and .net7
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @SaschaBa on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @SaschaBa on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
@pglombardo Do you know, when it will be merged? Can I help you somehow? |
|
Hi @SaschaBa - I am aiming for this week. |
Hi, isn't it possible to skip this verification check? You should see, that I signed it. At the moment it blocks a lot for us, that's why I need to ask again. ;-) Sorry |
|
Hi @SaschaBa, could I please ask you to sign the CLA again. We had an IT issue that yours got lost. I am really sorry about this. All the best |
Done |
Description
Every access of the Subscriptions property is now locked with a semaphore. User of the client should not access the Subscriptions, also this property is public, because they can not lock the access. Later the Subscriptions should not be public and be perhaps of type ConcurrentBag.
Related Issue
#225
Type of Change
Checklist
rake test)