fix: set correct hint annotations for tools #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the default hint annotations for MCP tools by explicitly setting read-only and destructive annotations based on each tool's actual behavior. The mcp-go library was incorrectly defaulting all tools to destructive, which has been corrected by explicitly marking read-only tools as non-destructive.
- Adds explicit
WithReadOnlyHintAnnotation(true)andWithDestructiveHintAnnotation(false)for all read-only tools - Corrects the default destructive behavior that was being applied to non-destructive operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/hbmcp/projects.go | Updates project-related tools with correct hint annotations for read-only operations |
| internal/hbmcp/faults.go | Updates fault-related tools with correct hint annotations for read-only operations |
stympy
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcp-go defaults the destructive hint annotation to
truefor all tools. This sets the read-only and destructive hint annotations explicitly for each tool based on its behavior.Fixes #7