Skip to content

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jun 6, 2025

Fixes #20460

@hrydgard hrydgard added this to the v1.19.1 milestone Jun 6, 2025
@hrydgard
Copy link
Owner Author

hrydgard commented Jun 7, 2025

On arm32 for android, I'm getting:

jni/../../ext/libchdr/deps/lzma-24.05/src/CpuArch.c:838: error: undefined reference to 'getauxval'

Looks like it's gonna need a patch?

This is probably because we're using a very old Android NDK. will upgrade soon, so might hold off on this until then.

@Pesa
Copy link
Contributor

Pesa commented Jun 7, 2025

According to this, getauxval is available since API level 18 (Android 4.3). I humbly suggest increasing minSdk to something a little less ancient :)
Even first-party stuff like Google Play services require API 19+ since July 2021, and API 21+ since August 2023.

@hrydgard
Copy link
Owner Author

hrydgard commented Jun 7, 2025

@Pesa I'm not increasing it for 1.19.1.

We've been running on really ancient phones for so long that it's almost become a point of pride, heh.

But, new requirements are coming and I will indeed have to bump soon. But not quite yet.

@Pesa
Copy link
Contributor

Pesa commented Jun 7, 2025

Yeah that's totally understandable, especially for a .1 release.

@anr2me
Copy link
Collaborator

anr2me commented Jun 9, 2025

May be similar to this issue ARM-software/ComputeLibrary#458

It wasn't clear how it got solved, but the last discussion seems to be advised to change the NDK to r16b (from r17) 🤔 That mean downgrading the NDK.

Anyway, since Google have dropped 32-bit app support, we will eventually need to use a separated (older) SDK & NDK version for 32-bit app (or no longer support 32-bit at some point)

@hrydgard
Copy link
Owner Author

I got a fix into the library checking for NDK version. Should be good now.

@hrydgard hrydgard merged commit 3eafb1b into master Jun 10, 2025
22 checks passed
@hrydgard hrydgard deleted the upgrade-libchdr branch June 10, 2025 13:24
hrydgard added a commit that referenced this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider updating libchdr
3 participants