Skip to content

Some cleanups #20483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Some cleanups #20483

merged 2 commits into from
Jun 10, 2025

Conversation

oltolm
Copy link
Contributor

@oltolm oltolm commented Jun 9, 2025

  1. I replaced strcmp with ==.
  2. When I ported to msys2 I used some ugly ifdefs in Core/MIPS/MIPSInt.cpp. I replaced the macros with inline functions.

@hrydgard hrydgard added this to the v1.20 milestone Jun 9, 2025
@hrydgard
Copy link
Owner

hrydgard commented Jun 9, 2025

I'll merge this after the 1.19.x releases are done.

@hrydgard hrydgard merged commit 552c1cc into hrydgard:master Jun 10, 2025
21 checks passed
@hrydgard hrydgard added the Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. label Jun 10, 2025
@oltolm oltolm deleted the inline branch June 10, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
2 participants
@oltolm @hrydgard