-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[ImDebugger] Enable Memory Search in the ImMemView Widget #20487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is cool. Two things: From an architecture perspective, maybe the UI should actually belong to the surrounding window rather than the MemView itself? Could just call methods on the MemView to set the search. When making UI PRs, please provide screenshots for quick evaluation :) |
- added a simple string search for string using char16 in memory (currently limite to ASCII)
It's still in draft mode - is it ready for review? |
I'll check it out soon, just got suddenly swamped with bug reports :) |
Btw, is the float only for single-precision? or double-precision too? in case there are games that use double-precision to store value that need higher precision, less likely but possible. |
Thanks for the feedback, |
There is some soft-fpu use of double in games, but of course much less than actual floats. So not sure if worth adding to a searcher. |
To fix the Windows error, on this line:
Rename FLOAT to FLOAT_32 to avoid clashing with some Windows typedef (ugh). Maybe also rename BYTESEQ to BYTE_SEQ for consistency with the others. Also maybe throw the Search UI into a ImGui::CollapsibleHeader. After that, I'm happy to merge! |
- added search highlight with green background in the hexview
This PR enables basic support for the search in memory view widget
I used the already existing search code as a base.
It adds a few controls above the hexview rather than using a dialog box
currently the following search are supported: