Skip to content

Conversation

jamespeapen
Copy link
Member

@jamespeapen jamespeapen commented Mar 21, 2025

  • the input confidence level q is now being used
  • lapply functions extracted so they can be tested
  • Assuming that we can use the compartment call made by extractOpenClosed() instead of recomputing. It used to have a hardcoded 0 as a cutoff in summarizeBootstraps() but had an input cutoff argument in extractOpenClosed() with default 0.
  • moved .isCompartmentOpen() to getABSignal.R - if we use the earlier open/closed call that's the only file it gets called in
  • update agrestiCoullCI() to return a dataframe row so it can work with vector inputs and return a dataframe that can be plugged into the mcols(est.ab)
  • vectorize CI computation
Unit: milliseconds
 expr          min        lq         mean       median     uq         max          neval
    lapply CI  188.891453 193.743578 200.713800 196.716700 198.881289 633.046724   100
 vectorized CI   3.807941   3.898602   3.963774   3.926279   3.975098   4.715911   100

…losed

Whether a compartment is open or closed is set by extractOpenClosed in
getABSignal so it needn't be re-computed. This call is also set with a
cutoff argument by extractOpenClosed while here only 0 is used as a
cutoff
agrestiCoullCI now returns CI as a data.frame row
@biobenkj biobenkj merged commit 190b404 into huishenlab:master Apr 10, 2025
1 check passed
@jamespeapen jamespeapen deleted the summarizeBoots branch April 28, 2025 13:55
@jamespeapen jamespeapen added this to the v2 milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants