Skip to content

Casos install script #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Casos install script #79

wants to merge 15 commits into from

Conversation

Fabian-Geyer
Copy link
Contributor

Added install script that

  • checks if Casos can be used
  • tries to add Casos to path if not yet done
  • checks for correct Casadi version
  • checks which solver is available

and prints the resulting overview in a table to the console.

One small issue remains: In my case when adding CasADi to the matlab path and running the install script again, CasADi does not work immediately. It seems like Matlab always needs a restart to be able to correctly call the toolbox.
This means that users might have to restart Matlab after adding CasADi. )

@Fabian-Geyer Fabian-Geyer requested review from tcunis and JOlucak August 9, 2024 16:05
@Fabian-Geyer Fabian-Geyer linked an issue Aug 9, 2024 that may be closed by this pull request
Copy link
Contributor

@tcunis tcunis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, but I am unsure if we should really give a warning if:

  • CaΣoS is not on the path yet (that seems to be the default case if the user runs the install script)
  • either of the conic solvers is not found (most users won't have all solvers)

Perhaps it suffices to print out some text in either case.

Edit: Tested on Mac w/ M3 processor.

@tcunis tcunis requested a review from renatoloureiro August 15, 2024 15:32
@tcunis
Copy link
Contributor

tcunis commented Aug 15, 2024

@JOlucak , @renatoloureiro please check the install script on your machines.

@renatoloureiro
Copy link
Contributor

The install script works as intended on my machine.

@tcunis tcunis removed the request for review from renatoloureiro January 30, 2025 14:11
@tcunis tcunis added this to the version-1.0.0-rc milestone Mar 10, 2025
Copy link
Contributor

@JOlucak JOlucak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the script does not work properly. SCS is installed on my computer but the script does not find it.

  • Check for the SCS issue
  • Add installation/availability of Clarabel solver

We could also think about adding some unit tests here to see if it runs as expected. To be discussed also with Torbjørn.

Copy link
Contributor Author

@Fabian-Geyer Fabian-Geyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the script does not work properly. SCS is installed on my computer but the script does not find it.

  • Check for the SCS issue
  • Add installation/availability of Clarabel solver

We could also think about adding some unit tests here to see if it runs as expected. To be discussed also with Torbjørn.

  • Can you check if scs is in the Matlab Path while running the script?
  • What output do you get when running >> which scs?

@Fabian-Geyer Fabian-Geyer requested a review from JOlucak May 14, 2025 08:40
Copy link
Contributor

@JOlucak JOlucak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarabel_mex non existence is correctly found. SCS it seemed something went wrong in startup.m where it should be actually added to the path. Now this issue is also resolved on my side.

I've found some new points that should be clarified.

  1. For scs we should also look for the .mex file to make sure it is really installed and ready for use.
  2. The current script only checks if things are available. Strictly speaking we are not installing anything. In this case we should rename it to e.g. "check_installation.m" or similar.
  3. If we want to "install" things, at least CaSoS root folder should be automatically added to the matlab path (if not available).

If we are checking the proper installation, we should definitely add a few basic test functions that check if casos is properly working

@tcunis tcunis removed this from the version-1.0.0-rc milestone Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation file
4 participants