-
Notifications
You must be signed in to change notification settings - Fork 0
Casos install script #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, but I am unsure if we should really give a warning if:
- CaΣoS is not on the path yet (that seems to be the default case if the user runs the install script)
- either of the conic solvers is not found (most users won't have all solvers)
Perhaps it suffices to print out some text in either case.
Edit: Tested on Mac w/ M3 processor.
@JOlucak , @renatoloureiro please check the install script on your machines. |
The install script works as intended on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the script does not work properly. SCS is installed on my computer but the script does not find it.
- Check for the SCS issue
- Add installation/availability of Clarabel solver
We could also think about adding some unit tests here to see if it runs as expected. To be discussed also with Torbjørn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the script does not work properly. SCS is installed on my computer but the script does not find it.
- Check for the SCS issue
- Add installation/availability of Clarabel solver
We could also think about adding some unit tests here to see if it runs as expected. To be discussed also with Torbjørn.
- Can you check if scs is in the Matlab Path while running the script?
- What output do you get when running
>> which scs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarabel_mex non existence is correctly found. SCS it seemed something went wrong in startup.m where it should be actually added to the path. Now this issue is also resolved on my side.
I've found some new points that should be clarified.
- For scs we should also look for the .mex file to make sure it is really installed and ready for use.
- The current script only checks if things are available. Strictly speaking we are not installing anything. In this case we should rename it to e.g. "check_installation.m" or similar.
- If we want to "install" things, at least CaSoS root folder should be automatically added to the matlab path (if not available).
If we are checking the proper installation, we should definitely add a few basic test functions that check if casos is properly working
Added install script that
and prints the resulting overview in a table to the console.
One small issue remains: In my case when adding CasADi to the matlab path and running the install script again, CasADi does not work immediately. It seems like Matlab always needs a restart to be able to correctly call the toolbox.
This means that users might have to restart Matlab after adding CasADi. )